Patch/updating with likes (!173) · Merge requests · Custom D / Zon Core · GitLab

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Robert Sinton requested to merge patch/updating_with_likes into feature/encryption May 18, 2019

What I did

Used or_where() instead of or_like() when preparing an update_where() query, as likes are ignored by CI when building the update command.
Corrected syntax on some other uses of like() that were intended to use 'or'.

Implications

I haven't tested the other corrections, but they should be pretty solid.
Not entirely sure what would happen if update_where() ended up with a mix of genuine wheres as well as likes — i.e. the ANDing and ORing involved.

Setup

None

How to test

Code review.
In AFES encryption branch, log in and then clear your user's bitauth_userdata.filemaker_contact_id value.
- Now change personal details, e.g. your first name. Check the bitauth_userdata table and confirm that you have a new FM contact ID, and that the others are still all different.
Consider testing the other or_like() changes.