Resolve "Option to send full response to custom action handlers" (!4) · Merge requests · NPM / cd-redux-helpers · GitLab

This is an archived project. Repository and other project resources are read-only.

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Sam Sehnert requested to merge 9-option-to-send-full-response-to-custom-action-handlers into develop Dec 13, 2018

What I Did

Added ACTION_RETURN_FULL_RESPONSE option for handling full responses
Added ACTION_DONT_CHUNK option to disable request chunking in createFetchDetailAction
Move error and response handler out to unified factories instead of inlined
Improved code commenting

Todo

README.md to document new options, and how to use them.
Jest tests to verify new factories are working as they should.

Testing

Ensure that this version of the library works correctly with existing implementations
Set ACTION_RETURN_FULL_RESPONSE against the responseData option and ensure it returns the full API response.
Set ACTION_DONT_CHUNK against the chunkSize option in createFetchDetailAction and ensure it DOESN'T chunk requests at 500 ids (default)

Closes #9 (closed)

Edited Dec 21, 2018 by Sam Sehnert