Feedback jan2021 (!8) · Merge requests · TPS Credit / TPS Design System · GitLab

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

David McLeod requested to merge feedback-jan2021 into master Feb 09, 2021

What I did

Fixes related to: https://git.customd.com/tps-credit/tenancy-application-form/-/merge_requests/2

made the "More" button on collapsible text more prominent
made an empty input that for form focus (for focusing on errors using https://github.com/final-form/final-form-focus) on elements that do not have an input (e.g. boolean input, array inputs that open items in modals).

How to test.

you can test the "More" button in storybook, but to test the form focus, you'll need to pull changes on https://git.customd.com/tps-credit/tenancy-application-form/-/merge_requests/2, run yarn and yarn start then submit a form with an error on a boolean (e.g. do not select an answer for the smoking question` or an error in a modal/array (e.g. no address marked as current)