Skip to content

Resolve "Carbon diffIn method non absolute values"

Jitu requested to merge 3-carbon-diffin-method-non-absolute-values into master

Closes #3 (closed)

  • Carbon v3, has breaking change related to diffIn* method, please look at this link https://carbon.nesbot.com/docs/#api-carbon-3 , the area which has got affected is when we try and set Cookie, the value is now coming as negative, which will essentially expire the cookie immediately, I have tested this behaviour happening on testing and also on my local. Also the signature of diffIn* methods have changed from returning int to float, so I am according taking ceiling value and casting it into int for compatibility.
Edited by Jitu

Merge request reports