Follow-up from "V3 Update - drop older php support and improve code"
-
public key should always be a string
-
private should aways be string
-
public_keys should be used to deal with the encryption of data.
-
keypair class should be able to encrypt / decrypt
-
keyset/collection class should be encrypt only with set of public keys
The following discussions from !4 (merged) should be addressed:
-
@sam started a discussion: Should we be swapping in our new template here?
- project: "custom-d/ci-templates" file: "coverage-standards.gitlab-ci.yml"
-
@sam started a discussion: Should this file be removed?
-
@sam started a discussion: I wonder to make handling of this function simpler for future implementations whether we shouldn't just coerce this to an array:
return (array)$this->publicKey;
-
@sam started a discussion: Same here — always make this an array:
return (array)$this->privateKey;
-
@sam started a discussion: protected array $publicKey;
-
@sam started a discussion: protected array $privateKey;