Event handling for login links (!127) · Merge requests · Custom D / Zon Core · GitLab

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Robert Sinton requested to merge feature/login_links into master Mar 06, 2018

What I did

Changed the event handling for .js__login links to apply to all links in the document at any time, not just those present at load time.

Implications

Allows login links added after page load to still function.

Setup

None

How to test

Code review.
Effectively the same change has been made in the custom zon-core branch for AFES. Log into AFES using FireFox — previously the login link in the nav menu would not work correctly, presumably due to a timing issue that only crops up in FF.