Improved the detection of curl timeouts in Xero transactions, distinguishing… (!136) · Merge requests · Custom D / Zon Core · GitLab

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Robert Sinton requested to merge patch/better_xero_timeout_detection into master Jun 22, 2018

What I did

Improved the detection of curl timeouts in Xero transactions, distinguishing them from 'Xero Entrust certificate expiry'.

Implications

This is the change recently committed into the Pulse custom zon-core branch.

Setup

None

How to test

Code review
Trial it in a real project, setting the Xero timeout to 1 second, or perhaps 0.1 seconds, to simulate a timeout.