Small change to error notification email generation (!154) · Merge requests · Custom D / Zon Core · GitLab

GitLab now enforces expiry dates on tokens that originally had no set expiration date. Those tokens were given an expiration date of one year later. Please review your personal access tokens, project access tokens, and group access tokens to ensure you are aware of upcoming expirations. Administrators of GitLab can find more information on how to identify and mitigate interruption in our documentation.

Robert Sinton requested to merge feature/rest_exception_notification_emailing into master Nov 06, 2018

This is just a very small change to reduce cognitive load for anyone reading this code.

What I did

Changed to use the recently-made-public notify->notify_admin() method instead of notify->set(), for code clarity.

Implications

None

Setup

None

How to test

Code review
Trigger a DF_REST_exception with a notification subject message parameter, and confirm that a notification email is still rent.