Skip to content

Patch/avoid blog notification failures

Robert Sinton requested to merge patch/avoid_blog_notification_failures into master

These changes are intended to resolve a problem experienced by Art Money, where new blog articles would eventually cause a 'Process Failed' error after a blogs/notifications queue job failed four times.

What I did

  • Updated the blog routing logic to prevent it treating the blog/notifications URL as a candidate for blog routing.
    • This change fixes what looks like a longstanding bug around the notification feature, where the blogs/notification queue job would presumably always fail?
  • Updated the blog notification logic to do nothing if the subscription feature is not enabled.

Implications

None

Setup

None

How to test

  • Code review
  • Test with a solution that uses blog articles. Commit cd6b63df56ad4d1df29d4a99da4be74beeb89ee8 in Art Money set up to use this zon-core branch.
  • Find a blogs/notification queue job record, and set it to waiting with zero retries
  • Load cron/run to process the job
  • Confirm that it changes to 'completed', instead of failing.
    • Note: the second change is required only if there are active subscriptions.

Task: https://preview.gotasman.com/projects/tasks/disable-email-notification-for-new-blog-articles-61443

Merge request reports