Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Zon Core Zon Core
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Custom D
  • Zon CoreZon Core
  • Merge requests
  • !174

Open
Created May 30, 2019 by Robert Sinton@robertMaintainer
  • Report abuse
Report abuse

Feature/xero if modified since

  • Overview 10
  • Commits 5
  • Changes 1

The Xero API allows for fetching items created or modified after a certain date by using the HTTP If-Modified-Since header. This change allows for easy use of that, including in a call chain, without having to separately set a header.

What I did

  • Added parameter specifications to the get() method definition in the DF_Xero_Public class, to avoid a PHP warning about it not matching the signature of the method from the DF_Xero class that it overloads.
  • Added an if_modified_since() utility method to DF_Xero, to allow for the common case of requesting items modified since a specified time.

Implications

None

Setup

None

How to test

  • Code review.
  • Can be tested with commit 104de2357cfcaaec87c4f858054e4819cbdafbcb from the National Weighing project
    • Different results can be viewed with these URLs:
    • https://www.nw.vm/xero_inventory/modified_since/2019-05-09T00:00:00
    • https://www.nw.vm/xero_inventory/modified_since/2019-05-10T00:00:00
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feature/xero_if_modified_since