Skip to content

WIP: Feature/on demand cropping

Sam Sehnert requested to merge feature/on_demand_cropping into master

What I Did

  • Improved ability to trigger saves manually by adding deferreds which are resolved when the save operation is completed
  • Created a new editable API method called ‘crop’ to tigger a crop externally
  • Moved the editable image crop into it’s own self-contained method
  • Improved the destroy method to better un-initialise an editable image in particular
  • Updated styles to properly show disabled zoom bars.
  • Updated docs and included an image editable use case (need to do more documentation on image editables)

Implications

Editable is used in a wide variety of places, but I have't significantly changed the operation of the plugin. Should be well tested.

How to test

  • Find or create an image editable region, and try to trigger a crop using the new method with an existing file from the files table.
  • Try various combinations of crop/non-crop, pre-populated, and image placeholder state with the new crop method.
  • Ensure cropped files are saved correctly.

Merge request reports