Skip to content

Refinement to auto-installed UserSeeder

Robert Sinton requested to merge feature/refinements-may-2024 into main

Background

A coupe of small refinements to the starting UserSeeder that the installer script adds.

Action Plan / Actions Taken

  • chore: Corrects the developer user's name to the normal usage of "Custom D".
  • chore: Adds clarifying comment about the need to change this seeded password immediately after deployment/seeding.

Implications

  • None

Setup

  • None

How to test

  • Code review.
  • Functional testing probably not required?
  • Try and break it!

Closes #490 Closes #491

Summary by CodeRabbit

  • Bug Fixes

    • Removed conditional logic related to regulatory compliance checks in the createCreditApplicationRecord method.
    • Removed RegulatoryComplianceException class import.
    • Removed RegulatoryComplianceException from the catch block in LinesOfCreditController.php.
    • Introduced conditional validation rules and custom error messages based on the us_bp_launch_2024 feature flag for US addresses in CreditApplicationRequest.php.

  • Tests

    • Added the use of PHPUnit\Framework\Attributes\DataProvider.
    • Added new test methods related to credit application records and feature flag states.
    • Added data provider attributes to the test methods.
    • Added a new method setUpTestData and modified test data structure setup.

Merge request reports